feat: remove new tab default on image credits #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image credits default to opening in a new tab. In general, opening in a new tab is actually not a great user experience, as it deprives the user of the freedom of whether to open it in the current tab or a new one. There are also accessibility considerations, as opening in a new tab makes the site problematic for users with disabilities who use assistive technologies. This handy guide explains why it’s not a great idea and details some narrow cases where it might be preferable: https://css-tricks.com/use-target_blank/ The thinking on this has evolved fairly recently, but current best practices are to open most, if not all, links in the same tab (with possible exceptions for when it opens a document like a PDF or something else that takes you out of your regular browser experience). There's more about the approach in this article from DMXzone: https://www.dmxzone.com/go/10742/free-beware-of-opening-links-in-a-new-window/ Publishers who insist on making this the default are welcome to install a separate plugin that enforces this behavior, as opposed to it being decided by the theme.
Image credits default to opening in a new tab. In general, opening in a new tab is actually not a great user experience, as it deprives the user of the freedom of whether to open it in the current tab or a new one. There are also accessibility considerations, as opening in a new tab makes the site problematic for users with disabilities who use assistive technologies. This handy guide explains why it’s not a great idea and details some narrow cases where it might be preferable: https://css-tricks.com/use-target_blank/ The thinking on this has evolved fairly recently, but current best practices are to open most, if not all, links in the same tab (with possible exceptions for when it opens a document like a PDF or something else that takes you out of your regular browser experience). There's more about the approach in this article from DMXzone: https://www.dmxzone.com/go/10742/free-beware-of-opening-links-in-a-new-window/ Publishers who insist on making this the default are welcome to install a separate plugin that enforces this behavior, as opposed to it being decided by the theme.
laurelfulford
added
the
[Status] Needs Review
dkoo
approved these changes
Feb 6, 2024
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Feb 8, 2024
# [3.1.0-alpha.1](v3.0.3...v3.1.0-alpha.1) (2024-02-08) ### Bug Fixes * **engagement-wizard:** handle error when retrieving subscription lists ([e85c108](e85c108)) * **ras:** only sync spend total and last payment amounts for completed orders ([#2886](#2886)) ([68aaf39](68aaf39)) * redirect to origin from magic link ([9f41947](9f41947)) * typescript errors ([dc27973](dc27973)) * TypeScript usage; add to CI ([#2884](#2884)) ([6f5e7a6](6f5e7a6)) * update newsletter scroll appearance in Sign Up modal ([#2897](#2897)) ([496723a](496723a)) ### Features * **ci:** add epic/* release workflow and rename `master` to `trunk` ([#2895](#2895)) ([ea02075](ea02075)), closes [#2897](#2897) [#2886](#2886) * **reader-revenue:** make NYP and Stripe Gateway optional ([#2866](#2866)) ([fcfa88c](fcfa88c)) * remove new tab default on image credits ([#2880](#2880)) ([3c996b1](3c996b1)) * **wc:** override cart, checkout, and my-account page templates ([#2893](#2893)) ([68b1836](68b1836))
|
🎉 This PR is included in version 3.1.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.1.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Feb 20, 2024
# [3.1.0](v3.0.5...v3.1.0) (2024-02-20) ### Bug Fixes * add frequency tab options for donations, even when tiers are disabled ([#2930](#2930)) ([cb7eb7b](cb7eb7b)) * **categories:** fix pager urls ([#2913](#2913)) ([bb7e534](bb7e534)) * **categories:** fix pager urls ([#2913](#2913)) ([c851bb6](c851bb6)) * **engagement-wizard:** handle error when retrieving subscription lists ([e85c108](e85c108)) * **ras:** only sync spend total and last payment amounts for completed orders ([#2886](#2886)) ([68aaf39](68aaf39)) * redirect to origin from magic link ([9f41947](9f41947)) * typescript errors ([dc27973](dc27973)) * TypeScript usage; add to CI ([#2884](#2884)) ([6f5e7a6](6f5e7a6)) * update newsletter scroll appearance in Sign Up modal ([#2897](#2897)) ([496723a](496723a)) * update path to wide template file ([#2918](#2918)) ([fdd6b69](fdd6b69)) ### Features * **ci:** add epic/* release workflow and rename `master` to `trunk` ([#2895](#2895)) ([ea02075](ea02075)), closes [#2897](#2897) [#2886](#2886) * **reader-revenue:** make NYP and Stripe Gateway optional ([#2866](#2866)) ([fcfa88c](fcfa88c)) * remove new tab default on image credits ([#2880](#2880)) ([3c996b1](3c996b1)) * **wc:** override cart, checkout, and my-account page templates ([#2893](#2893)) ([68b1836](68b1836))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Image credits with links currently default to opening in a new tab. In general, opening in a new tab is not a great user experience, as it deprives the user of the freedom of whether to open it in the current tab or a new one.
There are also accessibility considerations, as opening in a new tab makes the site problematic for users with disabilities who use assistive technologies.
This handy guide explains why it’s not a great idea and details some narrow cases where it might be preferable:
https://css-tricks.com/use-target_blank/
The thinking on this has evolved fairly recently, but current best practices are to open most, if not all, links in the same tab (with possible exceptions for when it opens a document like a PDF or something else that takes you out of your regular browser experience). There's more about the approach in this article from DMXzone:
https://www.dmxzone.com/go/10742/free-beware-of-opening-links-in-a-new-window/
WordPress 6.3 and later have downplayed the prevalence of new tab behavior, as seen in WordPress/gutenberg#50950
Publishers who prefer that credits open in a new tab are welcome to install a separate plugin that enforces this behavior, as opposed to it being decided by the theme.
How to test the changes in this Pull Request:
Other information: